Open
Conversation
Add channel number to log statements.
|
I tried your fork and it's not working correctly. With this many changes I would split them up into as many separate PRs as possible. This makes the maintainer's job easier. I like the idea of being able to specify antenna, etc. EDIT: I got it working, I did not have command line options in the right order apparently. But the app seg faults which means there's a problem somewhere. It may be that your new options need to be optional and not cause seg faults. But maybe that's an issue without this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My current fork add the following things:
This means you can do something like:
This create 2 files, one per channel, with channel 0 gain set to 50 and channel 1 gain set to 32, both using their LNAL antenna port with 9e6Hz of bandwidth on the 10Ms/s sampling.
Max number of channels is compile time set (currently 8).
For the long options '--gain 10', for example, would set the gain of all channels to be 10, so something like '--gain 10 --gain2 30' would set the gain of all channels to be 10 and then set channel 2 to be 30.
Thanks,
Matt