feat:add support to store multiple commands in NFC card#18
Open
ignasiduelo wants to merge 1 commit intoryanolf:mainfrom
Open
feat:add support to store multiple commands in NFC card#18ignasiduelo wants to merge 1 commit intoryanolf:mainfrom
ignasiduelo wants to merge 1 commit intoryanolf:mainfrom
Conversation
…eparated by line break
Owner
|
Hi @ignasiduelo, thanks for the PR! I think this feature sounds reasonable, but I'm not sure it adds much over what you can already do, which is have each command in its own record. Each card can have multiple records. What lead you to do this instead of using multiple records? |
Author
|
Ah you're totally right. |
Owner
|
I think making cards compatible between different implementations is
compelling. I’d rather you not have to reprogram your cards. I don’t really
see a downside to parsing each line as a command.
I’ll take a look when I’m back on my computer.
…On Fri, Nov 8, 2024 at 5:12 PM Ignasi Duelo ***@***.***> wrote:
Closed #18 <#18>.
—
Reply to this email directly, view it on GitHub
<#18 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJSBSSF2W6D3NFH6JFKY4DZ7TWGHAVCNFSM6AAAAABRNRLFV6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGIZDANRWGU2TKNA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Owner
|
What is the other tool that works this way? I wonder if there are other
commands or differences we want to consider.
…On Fri, Nov 8, 2024 at 6:53 PM Ryan Olf ***@***.***> wrote:
I think making cards compatible between different implementations is
compelling. I’d rather you not have to reprogram your cards. I don’t really
see a downside to parsing each line as a command.
I’ll take a look when I’m back on my computer.
On Fri, Nov 8, 2024 at 5:12 PM Ignasi Duelo ***@***.***>
wrote:
> Closed #18 <#18>.
>
> —
> Reply to this email directly, view it on GitHub
> <#18 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJSBSSF2W6D3NFH6JFKY4DZ7TWGHAVCNFSM6AAAAABRNRLFV6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGIZDANRWGU2TKNA>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
|
ryanolf
reviewed
Nov 11, 2024
Owner
ryanolf
left a comment
There was a problem hiding this comment.
If you can fix the one redundant call, this seems fine to merge.
| await process_sonos_command(command); | ||
| } | ||
|
|
||
| await process_sonos_command(received_text); |
Owner
There was a problem hiding this comment.
I think this call is redundant (in the case of a single line) and an error (in the event of multiple lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to store multiple commands in NFC card in text feld separated by line breaks, allowing things like storing a room change in a card and then playing an album from a particular track, such as: