Add filename to info window on map for easier photo ID #12
Open
Elizabethcase wants to merge 12 commits intoryanseys:masterfrom
Open
Add filename to info window on map for easier photo ID #12Elizabethcase wants to merge 12 commits intoryanseys:masterfrom
Elizabethcase wants to merge 12 commits intoryanseys:masterfrom
Conversation
ryanseys
reviewed
Jul 24, 2017
| } | ||
| } | ||
|
|
||
| // added ImageDescription/filename section |
ryanseys
reviewed
Jul 24, 2017
| // added ImageDescription/filename section | ||
| if(!exif_data || !exif_data.ImageDescription) { | ||
| // no image description available | ||
| var filename = "No Filename"; |
ryanseys
reviewed
Jul 24, 2017
| var filename = "No Filename"; | ||
| } | ||
| else { | ||
| var filename = exif_data.ImageDescription; |
ryanseys
reviewed
Jul 24, 2017
| ctx.drawImage(this, 0, 0, imageWidth, imageHeight); | ||
| var thumbnail_data = canvas.toDataURL("image/jpeg"); | ||
| addInfoWindow(marker, thumbnail_data, imageWidth, imageHeight, lat_deg, lon_deg); | ||
| addInfoWindow(marker, thumbnail_data, imageWidth, imageHeight, lat_deg, lon_deg, filename); // added filename |
ryanseys
reviewed
Jul 24, 2017
| if(exif_data.thumbnail) { | ||
| // yay! thumbnail found! | ||
| addInfoWindow(marker, exif_data.thumbnail, imageWidth, imageHeight, lat_deg, lon_deg); | ||
| addInfoWindow(marker, exif_data.thumbnail, imageWidth, imageHeight, lat_deg, lon_deg, filename); // added filename |
Owner
|
Thanks for the pull request! Just left a few small comments. |
map isn't loading so added &callback=initMap
changed callback = initMap to callback = initialize
ryanseys
reviewed
Jul 25, 2017
index.html
Outdated
| <meta name="viewport" content="initial-scale=1.0, user-scalable=no"> | ||
| <meta charset="utf-8"><link rel="stylesheet" href="css/style.css" type="text/css"> | ||
| <script src="https://maps.googleapis.com/maps/api/js?v=3.exp&sensor=false"></script> | ||
| <script async defer src="https://maps.googleapis.com/maps/api/js?v=3.exp&sensor=false&key=AIzaSyBECSPwBMmPm12XeEUhmXn6Bejl1ZsbnIo&callback=initMap" |
Owner
There was a problem hiding this comment.
I wouldn't suggest putting the API key in GitHub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(probably would be better as an option rather than default)
Displays filename along with lat/long in google map pin info window