fix for icpc build and new build option mkl#297
Open
joveh wants to merge 4 commits intos-mandra:masterfrom
Open
fix for icpc build and new build option mkl#297joveh wants to merge 4 commits intos-mandra:masterfrom
joveh wants to merge 4 commits intos-mandra:masterfrom
Conversation
icpc does not know -Wpedantic and -Wno-unused-command-line-argument
Intel MKL can also be used with g++ while icpc can also build with OpenBASE. Thus, a new configure option is required
joveh
changed the title
Contributor
|
Added @s-mandra to review Makefile / configure changes. Overall this seems OK to me, but I'm not deeply familiar with the files being changed. |
changed dependencies however this will be an issue at some point apps/quantumtools/2020-12/qflex/tests/python/simulation_test.py:607: DeprecationWarning: StateVectorTrialResult.final_state was used but is deprecated. It will be removed in cirq v0.10.0. Use final_state_vector instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix building Intel MKL
the last occurance
fix CXXFLAGS for icpc; remove specific options for g++
icpc does not know -Wpedantic and -Wno-unused-command-line-argument
add configure option "--enable-mkl" to use Intel MKL
Intel MKL can also be used with g++ while icpc can also build with
OpenBASE. Thus, a new configure option is required