chore: enable pedantic clippy lints

[shikhar]

No description provided.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR enables clippy::pedantic and clippy::nursery lint groups to improve code quality across the codebase. All changes are stylistic improvements that follow Rust best practices and idioms.

Key improvements:

• Added numeric separators to large literals (e.g., 1_700_000_000) for better readability
• Replaced type name repetition with Self in match arms and constructors
• Removed redundant .clone() calls in test code
• Inlined format arguments using modern Rust syntax
• Improved bool-to-int conversion using i64::from()
• Used Arc::default() for clearer type-specific defaults

Lint configuration:

• Enabled pedantic and nursery groups with sensible allow overrides
• Allowed noisy lints like missing_errors_doc, cast_*, and various style preferences
• Configuration aligns with the project's existing style preferences

The PR includes comprehensive allows for lints that would be too verbose or don't fit the project's coding style. All changes are verified by cargo clippy --all-features --all-targets -- -D warnings passing.

Confidence Score: 5/5

• This PR is completely safe to merge with zero risk
• All changes are purely stylistic code improvements from enabling clippy pedantic and nursery lints. No logic changes, no behavior changes, and the test suite passes. The lint configuration is well-considered with appropriate allows for noisy lints.
• No files require special attention

Important Files Changed

Filename	Overview
Cargo.toml	Added pedantic and nursery clippy lints with reasonable allow overrides for style preferences
src/cache.rs	Improved readability with numeric separators and inlined format args, removed redundant clones
src/service/metrics.rs	Replaced bool-to-int conditional with i64::from() conversion

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Clippy as Clippy Linter
    participant Code as Codebase
    
    Dev->>Code: Enable pedantic & nursery lints
    Dev->>Code: Add allow overrides for style preferences
    
    Clippy->>Code: Scan for lint violations
    
    Note over Clippy,Code: Code Quality Improvements
    
    Clippy->>Code: Flag unreadable numeric literals
    Dev->>Code: Add separators (1700000000 → 1_700_000_000)
    
    Clippy->>Code: Flag type name repetition
    Dev->>Code: Use Self instead of type names
    
    Clippy->>Code: Flag redundant clones in tests
    Dev->>Code: Remove unnecessary .clone() calls
    
    Clippy->>Code: Flag uninlined format args
    Dev->>Code: Inline format arguments
    
    Clippy->>Code: Flag bool-to-int pattern
    Dev->>Code: Use i64::from(bool)
    
    Clippy->>Code: Flag Default trait pattern
    Dev->>Code: Use Arc::default()
    
    Clippy->>Code: Re-scan with new config
    Note over Clippy,Code: All warnings resolved ✓

Loading