This repository was archived by the owner on Jan 30, 2026. It is now read-only.
Conversation
Greptile OverviewGreptile SummaryThis PR adds an
The implementation is consistent with existing config options and includes appropriate security warnings. The feature can be configured via config file or Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant CLI
participant ConfigLoader
participant CliConfig
participant SDKConfig
participant S2SDK
User->>CLI: Run s2 command
CLI->>ConfigLoader: load_cli_config()
ConfigLoader->>ConfigLoader: Load config.toml
ConfigLoader->>ConfigLoader: Load S2_SSL_NO_VERIFY env var
ConfigLoader->>CliConfig: Deserialize config with ssl_no_verify
CliConfig-->>CLI: Return CliConfig
CLI->>SDKConfig: sdk_config(config)
SDKConfig->>SDKConfig: Check config.ssl_no_verify
alt ssl_no_verify == Some(true)
SDKConfig->>SDKConfig: tracing::warn("SSL verification disabled")
SDKConfig->>S2SDK: with_insecure_skip_cert_verification(true)
end
SDKConfig-->>CLI: Return S2Config
CLI->>S2SDK: Execute API call with config
S2SDK-->>User: API response (without cert verification if enabled)
|
shikhar
pushed a commit
to s2-streamstore/s2-sdk-rust
that referenced
this pull request
Jan 27, 2026
... for the env var to disable SSL verification during tests. Renamed to match s2-streamstore/s2-cli#210
Merged
shikhar
pushed a commit
that referenced
this pull request
Jan 27, 2026
## 🤖 New release * `s2-cli`: 0.25.1 -> 0.25.2 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.25.2] - 2026-01-27 ### Bug Fixes - Add `S2_SSL_NO_VERIFY` config ([#210](#210)) ### Miscellaneous Tasks - Release cmd - Automate releases with release-plz - Add dependabot for weekly dependency updates ([#208](#208)) - Consolidate release workflows ([#211](#211)) <!-- generated by git-cliff --> </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config option to disable SSL certificate verification.
Name inspired by the corresponding git config override: https://git-scm.com/docs/git-config#Documentation/git-config.txt-httpsslVerify