Get ALL connections & contact groups #8
Open
quinn-p-mchugh wants to merge 3 commits intosVathis:masterfrom
Open
Get ALL connections & contact groups #8quinn-p-mchugh wants to merge 3 commits intosVathis:masterfrom
quinn-p-mchugh wants to merge 3 commits intosVathis:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where a limited number of connections and contact groups would be retrieved from the Google Contacts API. In my case, this would cause a
KeyErrorwhen the program would try to get the name of a non-existent contact group (based on its ID) for a particular connection.Using pagination handling, the code now continually calls the Google Contacts API until ALL connections and all contact groups on the user's account are retrieved.