Draft
Conversation
d-s-codappix
force-pushed
the
feature/updateV13
branch
from
2c46127 to
b99d030
Compare
d-s-codappix
force-pushed
the
feature/updateV13
branch
4 times, most recently
from
482d628 to
2aaa3d3
Compare
In order to execute all important code. That way PHPUnit can report PHP warnings and deprecations triggered by the code.
Those were found by test coverage.
d-s-codappix
force-pushed
the
feature/updateV13
branch
from
2aaa3d3 to
856b7e6
Compare
s12r
reviewed
Sep 25, 2025
| use PHP_CodeSniffer\Standards\PSR2\Sniffs\ControlStructures\ControlStructureSpacingSniff as PSR2ControlStructureSpacingSniff; | ||
| use PHP_CodeSniffer\Standards\PSR2\Sniffs\Methods\FunctionCallSignatureSniff as MethodsFunctionCallSignatureSniff; | ||
| use PHP_CodeSniffer\Standards\Squiz\Sniffs\WhiteSpace\OperatorSpacingSniff; | ||
| use PhpCsFixer\Fixer\ArrayNotation\ArraySyntaxFixer; |
There was a problem hiding this comment.
There are more use statements than classes used in the static function (e.g. PhpCsFixer\Fixer\ArrayNotation\ArraySyntaxFixer). Is it necessary to keep them here?
Author
There was a problem hiding this comment.
I've copied the file from EXT:variables and didn't check anything.
I'll have a look and clean things up, and will bring this change to EXT:variables as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only exists to have the CI reporting the current state.
It should be closed in the end and in favour of upstream PR visol#62