Fix controlled input state not reflecting in the input#239
Open
matiasperz wants to merge 3 commits intosadmann7:mainfrom
Open
Fix controlled input state not reflecting in the input#239matiasperz wants to merge 3 commits intosadmann7:mainfrom
matiasperz wants to merge 3 commits intosadmann7:mainfrom
Conversation
- Introduced a new demo for controlled mentions, showcasing user interactions with mentions in a chat-like interface. - Updated the registry to include the new demo and its dependencies. - Enhanced documentation to include the new demo under the mentions section, providing users with a clear example of usage. - Added necessary JSON files for the new demo in the public registry.
Contributor
|
@matiasperz is attempting to deploy a commit to the sadmann7 Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds controlled mode support for the
Mentioncomponent, allowing external state management of the open state, selected values, and input value. It includes a new demo showcasing the controlled usage pattern along with necessary bug fixes to properly sync controlled state.Changes
New Features
mention-controlled-demo.tsx): Added a new example demonstrating fully controlled usage of the Mention component in a message-sending interface. The demo shows:open,value, andinputValuestateBug Fixes
mention-input.tsx:useEffectto sync the controlledinputValueprop to the actual input DOM element, ensuring the input reflects external state changescontext.onValueChangeto the dependency array for proper state synchronizationmention-highlighter.tsx:inputElementto usingcontext.inputValuefor consistent behavior with controlled modeDocumentation