fix(SAFE-T1004): replace placeholder guidance and add rule tests#185
Open
bishnubista wants to merge 1 commit intosafe-agentic-framework:mainfrom
Open
fix(SAFE-T1004): replace placeholder guidance and add rule tests#185bishnubista wants to merge 1 commit intosafe-agentic-framework:mainfrom
bishnubista wants to merge 1 commit intosafe-agentic-framework:mainfrom
Conversation
bishnubista
force-pushed
the
codex/fix-safe-t1004-quality
branch
from
91b0bc8 to
f454833
Compare
- Rewrite SAFE-T1004 README to remove placeholder mitigations and incorrect related-technique mappings - Update detection rule to use actionable ODR matching and valid SAFE-MCP reference URLs - Relax unsupported ARP event-id assumption in detection logic - Expand test logs with positive/negative cases - Add runnable test_detection_rule.py validation script Signed-off-by: bishnubista <bista.developer@gmail.com>
bishnubista
force-pushed
the
codex/fix-safe-t1004-quality
branch
from
f454833 to
ac27c5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden SAFE-T1004 technique documentation, detection rule, and test coverage:
test_detection_rule.pyvalidation scriptType of Contribution
Checklist
git commit -s)Validation
python3 techniques/SAFE-T1004/test_detection_rule.pytechniques/SAFE-T1004/detection-rule.ymlwithyaml.safe_loadtechniques/SAFE-T1004/README.mdRelated Issues
N/A