Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest versions of chrome has to be downloaded via chrome-for-testing: https://chromedriver.chromium.org/downloads
Latest stable release of chrome could not be downloaded from https://chromedriver.chromium.org/ and not listed (e.g. https://chromedriver.storage.googleapis.com/LATEST_RELEASE_115)
Instead, stable and newer releases should be checked from chrome-for-testing API such as https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json (See: https://github.com/GoogleChromeLabs/chrome-for-testing#json-api-endpoints), then downloaded from url that looks like https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5790.170/win64/chrome-win64.zip
Note that this PR is a bit messy (e.g. adding '-chrome-for-testing' to the end of version number to mark that the version of chrome has to be downloaded from chrome-for-testing). but it works. See if you want to change the structure of your code such that my dirty hack is not needed.