Skip to content

feat(suse): use nfs-server service#45

Open
tacerus wants to merge 1 commit intosaltstack-formulas:masterfrom
tacerus:suse
Open

feat(suse): use nfs-server service#45
tacerus wants to merge 1 commit intosaltstack-formulas:masterfrom
tacerus:suse

Conversation

@tacerus
Copy link
Contributor

@tacerus tacerus commented Feb 15, 2024

Recent openSUSE Leap and SLE distributions ship the "nfs-server" service. Whilst "nfsserver" still works, it is only a pointer to the canonical "nfs-server". It makes sense to call "nfs-server" directly on any SUSE based distribution and to drop the Tumbleweed specific override.

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Use a uniform service name for any SUSE distribution.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

Recent openSUSE Leap and SLE distributions ship the "nfs-server"
service. Whilst "nfsserver" still works, it is only a pointer to the
canonical "nfs-server". It makes sense to call "nfs-server" directly
on any SUSE based distribution and to drop the Tumbleweed specific
override.

Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
@daks daks requested a review from a team March 2, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant