Merged
Conversation
samloop
force-pushed
the
samloop/improve-runner-logging
branch
7 times, most recently
from
b065b75 to
36f78c9
Compare
Pull Request Test Coverage Report for Build 14782896141Details
💛 - Coveralls |
samloop
force-pushed
the
samloop/improve-runner-logging
branch
3 times, most recently
from
b1368ed to
0f7c283
Compare
ran-arigur
reviewed
Apr 1, 2025
| e.runPass() | ||
| if err != nil && ctx.Err() != context.Canceled { | ||
| return err | ||
| return oops.Wrapf(err, "Executor failed to run task") |
There was a problem hiding this comment.
Can we try this out, and see what it looks like now when a task fails — preferably both in TUI mode and in non-TUI mode — just in case it turns out to be weird/bad/confusing in some way?
Contributor
Author
There was a problem hiding this comment.
Tested this - this error will only show up in the non UI version of Taskrunner
github.com/samsarahq/taskrunner.(*Executor).runPass.(*Executor).runPass.func1.func2: Executor failed to run task "tr-error-test"
github.com/taskrunner/executor.go:648
golang.org/x/sync/errgroup.(*Group).Go.func1
/home/ubuntu/co/backend/go/pkg/mod/golang.org/x/sync@v0.0.0-20200317015054-43a5402ce75a/errgroup/errgroup.go:57
github.com/samsarahq/taskrunner.Run.func4: running executor
This clarifies some error messages, and provides the stack trace when taskrunner fails on execution.
samloop
force-pushed
the
samloop/improve-runner-logging
branch
from
0f7c283 to
4754024
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This clarifies some error messages, and provides the stack trace when taskrunner fails on execution.