clireporter: add space after separator for IDE file link detection#80
Closed
dansamsara wants to merge 1 commit intomasterfrom
Closed
clireporter: add space after separator for IDE file link detection#80dansamsara wants to merge 1 commit intomasterfrom
dansamsara wants to merge 1 commit intomasterfrom
Conversation
The pipe separator was immediately followed by the filename with no space, causing IDEs (VS Code integrated terminal) to interpret the | as part of the filename when cmd+clicking to open files from log output. Before: taskname |filename.go:123 After: taskname | filename.go:123
Pull Request Test Coverage Report for Build 21689890501Details
💛 - Coveralls |
Contributor
Author
|
Closing - the issue is actually in the TUI border padding, not the clireporter separator. The fix needs to be in samsara-dev/backend's terminalui code instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When taskrunner outputs logs with filenames (e.g., from
typecheck), the pipe separator immediately precedes the filename with no space:This causes VS Code (and other IDEs) integrated terminals to interpret the
|as part of the filename when using cmd+click to open files, resulting in a "file not found" dialog.Solution
Add a trailing space to the separator:
"|"→"| "This allows IDEs to correctly detect and open the file path.
Testing
prefixedwriter.go- the separator is used directly in the format string with no additional spacingFixes: https://samsara.slack.com/archives/C02KRH25X2E/p1736197501140599