Skip to content

clireporter: add space after separator for IDE file link detection#80

Closed
dansamsara wants to merge 1 commit intomasterfrom
dansamsara/fix-separator-spacing
Closed

clireporter: add space after separator for IDE file link detection#80
dansamsara wants to merge 1 commit intomasterfrom
dansamsara/fix-separator-spacing

Conversation

@dansamsara
Copy link
Contributor

Summary

  • Add trailing space to the pipe separator in log output so IDEs can correctly parse filenames

Problem

When taskrunner outputs logs with filenames (e.g., from typecheck), the pipe separator immediately precedes the filename with no space:

     typecheck |go/src/samsaradev.io/api/foo.go:123:45 error message

This causes VS Code (and other IDEs) integrated terminals to interpret the | as part of the filename when using cmd+click to open files, resulting in a "file not found" dialog.

Solution

Add a trailing space to the separator: "|""| "

     typecheck | go/src/samsaradev.io/api/foo.go:123:45 error message

This allows IDEs to correctly detect and open the file path.

Testing

  • Build passes
  • Verified the output format in prefixedwriter.go - the separator is used directly in the format string with no additional spacing

Fixes: https://samsara.slack.com/archives/C02KRH25X2E/p1736197501140599

The pipe separator was immediately followed by the filename with no space,
causing IDEs (VS Code integrated terminal) to interpret the | as part of the
filename when cmd+clicking to open files from log output.

Before: taskname |filename.go:123
After:  taskname | filename.go:123
@coveralls
Copy link

Pull Request Test Coverage Report for Build 21689890501

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 45.167%

Changes Missing Coverage Covered Lines Changed/Added Lines %
clireporter/cli.go 0 2 0.0%
Totals Coverage Status
Change from base Build 19178823281: 0.0%
Covered Lines: 944
Relevant Lines: 2090

💛 - Coveralls

@dansamsara
Copy link
Contributor Author

Closing - the issue is actually in the TUI border padding, not the clireporter separator. The fix needs to be in samsara-dev/backend's terminalui code instead.

@dansamsara dansamsara closed this Feb 4, 2026
@dansamsara dansamsara deleted the dansamsara/fix-separator-spacing branch February 4, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants