Skip to content

Comments

feat: add 2in7 v2 support#100

Open
Suniron wants to merge 1 commit intosamsonmking:mainfrom
Suniron:feat/add-2in7-v2-support
Open

feat: add 2in7 v2 support#100
Suniron wants to merge 1 commit intosamsonmking:mainfrom
Suniron:feat/add-2in7-v2-support

Conversation

@Suniron
Copy link

@Suniron Suniron commented Aug 31, 2024

No description provided.

@jflorimo
Copy link

i could not compile the 2in7-v2

`
│ ../src/c/EPD_2in7_V2_node.cc: In function Napi::Value Display(const Napi::CallbackInfo&)

│ ../src/c/EPD_2in7_V2_node.cc:28:67: error: too many arguments to function ‘void EPD_2IN7_V2_Clear()’
│ 28 | EPD_2IN7_V2_Clear(reinterpret_cast<uint8_t *>(jsBuffer.Data()));
│ | ^
│ In file included from ../src/c/EPD_2in7_V2_node.cc:4:
│ ../src/c/EPD_2in7_V2.h:43:6: note: declared here
│ 43 | void EPD_2IN7_V2_Clear(void);
│ | ^~~~~~~~~~~~~~~~~
│ make: *** [waveshare2in7v2.target.mk:118: Release/obj.target/waveshare2in7v2/src/c/EPD_2in7_V2_node.o] Error 1
│ gyp ERR! build error
`

@jflorimo
Copy link

jflorimo commented Nov 22, 2024

replacing EPD_2IN7_V2_Clear by EPD_2IN7_V2_Display in EPD_2in7_V2_node.cc line 28 fix the issue.
Its working great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants