Skip to content

Y25-598 - scRNA - add tube size options#2645

Open
andrewsparkes wants to merge 15 commits intodevelopfrom
y25-598-scrna-add-tube-size-options
Open

Y25-598 - scRNA - add tube size options#2645
andrewsparkes wants to merge 15 commits intodevelopfrom
y25-598-scrna-add-tube-size-options

Conversation

@andrewsparkes
Copy link
Member

Closes #5389

Changes proposed in this pull request

  • change to viability threshold value

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 28.57143% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.53%. Comparing base (69b9ec5) to head (c7e11b8).

Files with missing lines Patch % Lines
...models/presenters/donor_pooling_plate_presenter.rb 28.57% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2645      +/-   ##
===========================================
- Coverage    84.59%   84.53%   -0.06%     
===========================================
  Files          501      501              
  Lines        20538    20559      +21     
  Branches       377      377              
===========================================
+ Hits         17374    17380       +6     
- Misses        3161     3176      +15     
  Partials         3        3              
Flag Coverage Δ
javascript 79.71% <ø> (ø)
pull_request 84.53% <28.57%> (-0.06%) ⬇️
push 84.53% <28.57%> (-0.06%) ⬇️
ruby 92.39% <28.57%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrewsparkes andrewsparkes linked an issue Dec 1, 2025 that may be closed by this pull request
6 tasks
Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
I'm still not a fan of the numbers and point punctuation in the purpose names, but realise that it might not be a simple change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y25-598 - Add New Tube and Plate Purposes to scRNA Core Pipeline

2 participants