Add transfer request collections #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proskurina
reviewed
Jun 8, 2017
| @object.__send__(:uuid_only?) | ||
| end | ||
|
|
||
| delegate :hash, to: :uuid |
andrewsparkes
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
45a33dd - Simple commit, adds transfer request collections and transfer requests. Transfer requests have been added as a separate model, rather then just using the existint request API to ensure they can be kept lightweight and simple. Existing requests rended a substantial ammount of information, including full representations of the target assets. This was particularly an issue here, as potentially one tube would be rendered in full 96 times. Resulting in 96*96 copies of the sample metadata.
d0f598 - Add support for nested_attributes_for to this side of the API. The support was almost there, but a bug assumed that the root json would be be present, even when configured otherwise. This fixes that bug, and ensures there is test coverage.