Remove the y24_052_enable_data_release_timing_validation feature flag

[KatyTaylor]

Changes proposed in this pull request

• Remove the y24_052_enable_data_release_timing_validation feature flag
• It was introduced in 'Y24-052 [BUG] Dropdown list dependencies', to turn the new server-side validation off until the existing data was fixed
• It can be removed after 'Y24-058 [BUG] Study data release information - data clean up' is done

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

[StephenHulme]

Hi @KatyTaylor Can this PR be merged in, or is it still waiting on something?

[KatyTaylor]

Hi @StephenHulme , no it can't be merged in, as it introduces server-side validation and there are lots of existing records that would fail the validation. #4084 was meant to resolve this - @neilsycamore did look into it, but I think he left the ball in the SSRs' court. If you re-run the queries here you can see none of the records that failed validation have been fixed. It might be more realistic to give up on the server-side validation and remove the feature flag in a different way.

[neilsycamore]

Hi @StephenHulme , no it can't be merged in, as it introduces server-side validation and there are lots of existing records that would fail the validation. #4084 was meant to resolve this - @neilsycamore did look into it, but I think he left the ball in the SSRs' court. If you re-run the queries here you can see none of the records that failed validation have been fixed. It might be more realistic to give up on the server-side validation and remove the feature flag in a different way.

Have not heard back from SSRs (email sent 25/10/24)

[StephenHulme]

All for closing this. Does this mean the flag is still in use or not?

If we aren't using the flag as a flag, can we remove it from the code and hard-code either execution path instead?

[KatyTaylor]

Yes we can remove the flag and hardcode an execution path - but not the one that this PR does. I'll spend half an hour and see if I can get it done.

Update - created PR to do the opposite - #5411