Skip to content

Y25-598 - scRNA - add tube size options#5389

Open
andrewsparkes wants to merge 14 commits intodevelopfrom
y25-598-scrna-add-tube-size-options
Open

Y25-598 - scRNA - add tube size options#5389
andrewsparkes wants to merge 14 commits intodevelopfrom
y25-598-scrna-add-tube-size-options

Conversation

@andrewsparkes
Copy link
Member

Closes #2597

Changes proposed in this pull request

  • change to viability threshold value

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.38%. Comparing base (22a5a65) to head (75bc565).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5389      +/-   ##
===========================================
+ Coverage    87.34%   87.38%   +0.03%     
===========================================
  Files         1462     1462              
  Lines        32947    32947              
  Branches      3457     3457              
===========================================
+ Hits         28778    28790      +12     
+ Misses        4148     4136      -12     
  Partials        21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,I've added some minor comments

Comment on lines 18 to 19
- LRC Bank Input 1ml
- LRC Bank Input 0.8ml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Capacities in purposes are somewhat against our usual pattern I think? Could these be replaced with labware part numbers or Sm/Md/Lg?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree but this is what Abby requested they be called.
I think they are the same tube model loaded with a different (specific) volume for use in one of the two specific prep methods, so part numbers or vague size descriptions doesn't work. Perhaps she has a name for each path that could be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y25-598 - Add New Tube and Plate Purposes to scRNA Core Pipeline GPL-nnn Refactor suppression of well creation

2 participants