Y25-681 Bulk submission and request additional sequencing - add 250 read length for novaseq6000 sp flowcell

[andrewsparkes]

Closes #5355

Changes proposed in this pull request

Adds validation to allow 250 read length for NovaSeq 6000 paired end bulk submission and to requests for additional sequencing, when using flowcell type SP.

[codecov]

Codecov Report

❌ Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.30%. Comparing base (cae30e7) to head (bdb45e2).

Files with missing lines	Patch %	Lines
...ib/record_loader/request_type_validators_loader.rb	66.66%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5456      +/-   ##
===========================================
- Coverage    87.35%   87.30%   -0.05%     
===========================================
  Files         1462     1463       +1     
  Lines        32966    33003      +37     
  Branches      3461     3467       +6     
===========================================
+ Hits         28796    28813      +17     
- Misses        4149     4169      +20     
  Partials        21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[KatyTaylor]

OK so this won't conflict in prod because it will only run if the Request Type doesn't exist. However, it will run when setting up your local environment from scratch. And it duplicates the record loader creation of the request type and request type validator. Not ideal - should ideally get rid of this one. Potentially complicated thought because of all the related records...?

Also, this version of the RequestTypeValidator doesn't set the key.

[andrewsparkes]

hmm, fair point.
and that explains why a lot of keys were null in the DB
I can see if I can remove this setup

[yoldas]

I think it needs read length request information type record in config/default_records/pipeline_request_information_types/default_records.yml but it is already created in the database.

select * from sequencescape_production.pipeline_request_information_types prit 
join sequencescape_production.request_information_types rit on prit.request_information_type_id = rit.id
join sequencescape_production.pipelines p on prit.pipeline_id = p.id
where p.name = 'NovaSeq 6000 PE';

[StephenHulme]

LGTM