x1290 support multiple addresses in plan/confirm sectioning#598
x1290 support multiple addresses in plan/confirm sectioning#598
Conversation
Add slot group entity. Remove support for creating regions in sectioning.
| """The section number of the new section.""" | ||
| newSection: Int | ||
| """The comment ids to record against this sample in this slot.""" | ||
| commentIds: [Int!] |
There was a problem hiding this comment.
Hi David, just double checking of the use of addressComments within the object ConfirmSectionLabware, the UI only allows to user to set comment per group section, which they will be sent within the param commentIds here. I checked the core and it is storing both.
There was a problem hiding this comment.
I think that's OK if I understand. The field might have formerly been the preferred way of sending comments and not used any more.
There was a problem hiding this comment.
Thanks! Just wanted to double-check whether the core expects the same comment to be stored in both objects, and if not, whether there are any fallbacks when creating views...
There was a problem hiding this comment.
It's an alternative way to specify comments. You definitely do not need to specify both
Add slot group entity.
Remove support for creating regions in sectioning.