Skip to content

x1290 support multiple addresses in plan/confirm sectioning#598

Merged
khelwood merged 3 commits intodevelfrom
slot_group
Dec 19, 2025
Merged

x1290 support multiple addresses in plan/confirm sectioning#598
khelwood merged 3 commits intodevelfrom
slot_group

Conversation

@khelwood
Copy link
Contributor

Add slot group entity.
Remove support for creating regions in sectioning.

Add slot group entity.
Remove support for creating regions in sectioning.
@khelwood khelwood requested a review from sabrine33 November 24, 2025 17:21
"""The section number of the new section."""
newSection: Int
"""The comment ids to record against this sample in this slot."""
commentIds: [Int!]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi David, just double checking of the use of addressComments within the object ConfirmSectionLabware, the UI only allows to user to set comment per group section, which they will be sent within the param commentIds here. I checked the core and it is storing both.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's OK if I understand. The field might have formerly been the preferred way of sending comments and not used any more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just wanted to double-check whether the core expects the same comment to be stored in both objects, and if not, whether there are any fallbacks when creating views...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an alternative way to specify comments. You definitely do not need to specify both

@khelwood khelwood merged commit 181eb3b into devel Dec 19, 2025
1 check passed
@khelwood khelwood deleted the slot_group branch December 19, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants