Conversation
Contributor
Author
|
I'll fix tests later, I've been thinking about the broader issue about this all day, and wanted to get my thoughts down before the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the practice of prepending an 'X' character to the typeURI field in CADF events when the resource type is not explicitly defined in the audit mapping configuration.
Problem:
Currently, when the audit middleware encounters an API path segment for which no resource mapping exists, it dynamically creates a specification. As part of this process, it prepends an 'X' to the derived resource name, which results in typeURIs like service/Xresource-name.
While this 'X' was intended as an internal indicator for developers to identify endpoints needing proper mapping, it appears in the final, customer-facing audit events. This causes confusion for users as the 'X' is undocumented and has no defined meaning from their perspective.
Solution:
The middleware already logs a clear warning message (e.g., unknown resource: (created on demand)) when it encounters an undefined resource type. This logging is sufficient for internal purposes (identifying missing mappings).
#112