Skip to content

modify the process order and change the feedin to send once has data#43

Merged
n0thingNoob merged 8 commits intomainfrom
new_verify_update
Feb 28, 2026
Merged

modify the process order and change the feedin to send once has data#43
n0thingNoob merged 8 commits intomainfrom
new_verify_update

Conversation

@n0thingNoob
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reorders the core’s per-cycle processing and updates the driver’s FeedIn/Collect logic to be opportunistic (per-port) rather than round/barrier-based, aiming to improve forward progress when only some ports can send/receive.

Changes:

  • Reordered core.Core.Tick() to perform receive before executing the program, and send after.
  • Refactored driverImpl feed-in/collect tasks to track progress per port (portRounds) instead of a single global round.
  • Updated feed-in/collect indexing to use per-port progress when selecting data positions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
core/core.go Changes core tick order to doRecv -> runProgram -> doSend per cycle.
api/driver.go Makes FeedIn/Collect opportunistic with per-port progress tracking and per-port indexing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI commented Feb 26, 2026

@n0thingNoob I've opened a new pull request, #44, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link

Copilot AI commented Feb 26, 2026

@n0thingNoob I've opened a new pull request, #45, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link

Copilot AI commented Feb 26, 2026

@n0thingNoob I've opened a new pull request, #46, to work on those changes. Once the pull request is ready, I'll request review from you.

@n0thingNoob
Copy link
Contributor Author

Can you review the code again? @copilot code review[agent]

Copy link

Copilot AI commented Feb 28, 2026

@n0thingNoob I've opened a new pull request, #47, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Collaborator

@Jackcuii Jackcuii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n0thingNoob n0thingNoob merged commit 635fff0 into main Feb 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants