modify the process order and change the feedin to send once has data#43
modify the process order and change the feedin to send once has data#43n0thingNoob merged 8 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Reorders the core’s per-cycle processing and updates the driver’s FeedIn/Collect logic to be opportunistic (per-port) rather than round/barrier-based, aiming to improve forward progress when only some ports can send/receive.
Changes:
- Reordered
core.Core.Tick()to perform receive before executing the program, and send after. - Refactored
driverImplfeed-in/collect tasks to track progress per port (portRounds) instead of a single globalround. - Updated feed-in/collect indexing to use per-port progress when selecting data positions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| core/core.go | Changes core tick order to doRecv -> runProgram -> doSend per cycle. |
| api/driver.go | Makes FeedIn/Collect opportunistic with per-port progress tracking and per-port indexing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@n0thingNoob I've opened a new pull request, #44, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@n0thingNoob I've opened a new pull request, #45, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@n0thingNoob I've opened a new pull request, #46, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
Can you review the code again? @copilot code review[agent] |
|
@n0thingNoob I've opened a new pull request, #47, to work on those changes. Once the pull request is ready, I'll request review from you. |
No description provided.