Open
Conversation
….hh, to keep compatibility.
…n for added Apple Clang compiler support.
Contributor
Author
|
So, I'm sorry, that this is so much, I promise I will do pull request more incrementally in the future. |
Contributor
Author
|
I have also added the fix for the matsubara quadrature segmentation fault, since I have not seen it in the main branch. |
Owner
|
I have two minor issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes across multiple files, focusing on build system updates, code improvements, and test enhancements. The most significant changes include updates to the build configuration, improvements to the
build_loggerfunction, adjustments to mathematical functions, and the addition of new tests. Below is a breakdown of the most important changes:Build System Updates:
.dockerignoreto exclude build artifacts and logs from Docker builds. (.dockerignore)setup_targets.cmakefromDiFfRG/CMakeLists.txt, simplifying the build configuration. (DiFfRG/CMakeLists.txt)setup_build_system.cmake. (DiFfRG/cmake/setup_build_system.cmake)debug,release, etc.) fromsetup_targets.cmake. (DiFfRG/cmake/setup_targets.cmake)Dockerfileto switch the base image from Rocky Linux to Ubuntu and updated installation steps for dependencies. (Dockerfile)Code Improvements:
build_loggerfunction inutils.ccto reuse existing loggers if available, reducing redundant logger creation. (DiFfRG/src/DiFfRG/common/utils.cc)regulators.hhto replace\partial_twith\partial_kfor better accuracy in describing derivatives. (DiFfRG/include/DiFfRG/physics/regulators.hh) [1] [2] [3] [4] [5] [6]Test Enhancements:
build_loggerfunction to verify its creation and retrieval behavior. (DiFfRG/tests/common/test_logger.cc)test_loggerin the test configuration. (DiFfRG/tests/common/CMakeLists.txt)std::riemann_zetawithboost::math::zetafor improved compatibility in loop integral tests. (DiFfRG/tests/physics/test_loop_integrals.cc) [1] [2]Mathematica Code Enhancements:
complex<double>as a known C type inCodeTools.mand introduced a function to project complex types to simpler types. (Mathematica/DiFfRG/CodeTools.m) [1] [2]CodeTools.m. (Mathematica/DiFfRG/CodeTools.m) [1] [2]These changes collectively improve the build process, enhance code clarity and functionality, and strengthen test coverage.