Skip to content

Conversation

@Maelstromeous
Copy link
Member

@Maelstromeous Maelstromeous commented Jan 30, 2025

Closes #11
Closes #401
Partial #54
Partial #394

Adds Building Groups for Products, and with it, Overclocking. This opens up an a tray, where you can split the buildings up however which way you wish.

Also standardizes all product number inputs to use v-number-input which has more useful control of minimums and styling of number inputs.

Todo

Common

  • Remove the concept of Basic & Advanced modes, it's too confusing for people. Add a toggle button to sync the building groups with the product and vice versa. Default it to On.
  • Implement Product / Power Producer item syncing with building groups (tests completed)
    • Groups -> Product
    • Product -> Groups via rebalance
    • When desynced and product buildings edited, remaining numbers are not updating
  • Implement debounce on changing:
    • Product Byproducts
    • Product Ingredients
    • Power Producer Ingredients
    • Power Producer Byproducts
  • Refactor how and when rebalancing is executed. Right now as soon as a new group is added it rebalances.
    • Rebalance ONLY when invoked by the user OR when product building count is updated and sync is ENABLED.
  • Bug: Editing product via a byproduct or ingredient does not properly update the building group to match (although weirdly certain metrics do)
    • Bug: Updating product via ingredient / byproduct does not update the building count of the prouduct (probably root cause)
  • Bug: When a product is freshly added, it's added with a 0.00x of a building count, it should added with 1.
  • Bug: Cannot update buildings on a power producer.
  • Bug: When updating the building counts, the item requirements calculations lag by one change.
  • Bug: Updating the Items' buildings does not update the effective building count in the item's building groups.
  • Bug: Updating Group via ingredients does not update the building count of the product to match the building group's count
  • Bug: Updating via ingredients does not match exactly what the user entered, e.g. 25.56 iron rods turns into 25.8, looks like it's trying to match whole numbers for clock speeds.
  • Bug: Upon adding a building group, and changing the building count, group metrics do not update.
    • Bug: Updating overclock is not updating any other metrics.
  • Bug: Raw item color not showing up for ingredients in Building Group part list.
  • Convert the UI into a tray which opens up at the bottom of the Product display (for cleanliness).
  • When user changes the recipe, delete all logical groups. This must be done as it will screw up the calculations significantly.
  • Reintroduce power consumption back per line, somehow
  • Ensure the user cannot enter more than a 250% overclock
  • Implement overclocking on building groups
  • Overclocked machines do not properly change their ingredients / production according to the overclock.
  • Make greyed out look on product up and down arrows less white (outline?)
  • Group problems are not assessed when using remainder buttons
  • Fix templates
  • Power should be shown on a per-group basis
  • Factory Building count should take into account all building groups
  • Factory Power summary should take into account all building groups power
  • Visual: Battery scenario where it should be going onto two lines with lots of resources
  • Creating a product / power producer creates a building group with 0.xx buildings, should be 1 building with an under-clock.
  • Ensure pre-update current factory plans have building groups generated and factories recalculated.
  • Refactor to enable BuildingGroup(s) code to be used by both Products and Power Producers
  • Bug: When using remainder buttons, the line doesn't update with power and ingredients used
  • GameSync support for building groups.
  • MOTHER OF GOD ALL THE TESTS

Product

  • Bug: Cannot update buildings on product.
  • Adjust building group counts via ingredients
  • Adjust building group counts via byproducts
  • Adjust building group counts via product production
  • Bug: Evenly balance does not trigger part calculations
  • Bug: Updating the building count does not change the group's power consumption

Power Producers

  • Bug: Cannot update group buildings
  • Bug: Updating the group buildings and in sync makes the "correct" status show up red when it's actually correct.
  • Show energy production on Power Producer groups
  • Overclocking on Power Producers.
    • Ingredient scaling wiki
  • Part calculation for power producers.
    • Bug: Producer Part math is way off. Tests pass however so there's a bug with re-calculations somewhere.
Screenshot 2025-02-21 at 16 20 53
  • Bug: Coal Generators 2nd ingredient is not calculated (water)
  • Templating for power producers to show parts (should automatically happen with calculations)
  • Bug: Power Producer building amount is visually wonky (probably a class thing)
  • Bug: Updating group building count does not update factory power producer building count
  • Fix building group controls to match product
  • Adjust building counts & overclock via ingredients
  • Adjust building counts & overclock via byproducts
  • Adjust building counts & overclock via power production CBA my brain is already mush!
  • Byproduct showing up as an ingredient (NuclearWaste)
  • Bug: Updating building count does not update the power production of the group.
  • Balancing buttons tests
    • Remainder to last does not update metrics
    • Remainder to new group does not create a new group
  • Overlapping UI elements on smaller screens
Screenshot 2025-02-24 at 17 14 41

Testing

  • Copying a factory should preserve the groups
  • Deleting a factory should delete all groups
  • Deleting a product group should not re-balance
  • Deleting a product group then creating a new one should not re-balance, and the balance buttons should show
  • Manually adjusting the clock speed should reflect the changes in the UI for the user

Building groups

  • When total ingredients change, singular build groups should be updated to match
    • Advanced mode should not change building groups when product is updated
  • When total ingredients change, the building count should change (as before)

Operations sheet

Since the building groups adds MANY interactions with the user, below is the status of the operations

@vercel
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
satisfactory-factories Error Error Sep 4, 2025 9:45pm

…dded styling changes so they're all consistent now.
…t, and added styling changes so they're all consistent now.
@Maelstromeous Maelstromeous changed the title Add Product Building Groups Add Product Building Groups, standardize number inputs Jan 31, 2025
…product. Added effective building calculation.
@Maelstromeous Maelstromeous changed the title Add Product Building Groups, standardize number inputs Overclocking Support, Product Groups, Numerical Input standardization Feb 3, 2025
@Maelstromeous Maelstromeous changed the title Overclocking Support, Product Groups, Numerical Input standardization Overclocking Support, Product Building Groups, Numerical Input standardization Feb 5, 2025
# Conflicts:
#	web/src/components/planner/products/PowerProducer.vue
#	web/src/components/planner/products/Product.vue
#	web/src/config/config.ts
#	web/vite.config.mts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Power Producers: Add ability to edit quantity via byproduct and ingredient Overclocking Support

4 participants