add rules to ban domains with constraints

[johnmastro]

Ban creating domains with constraints (CREATE DOMAIN ... CHECK) or adding constraints to existing domains (ALTER DOMAIN ... ADD CONSTRAINT).

Domains with constraints are hard to use/operationalize well with online migrations, have performance problems, and are soft-discourage by Postgres developers as having unfavorable tradeoffs.

[netlify]

👷 Deploy request for squawkhq pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	7d840eb

[johnmastro]

i couldn't find direct documentation, or even a clear place to cite in the libpg_query code, to demonstrate that subtype == "C" means it's the add constraint variation of alter domain. but, i have every other form in the "shouldn't report errors" test (ban_alter_domain_without_add_constraint_is_ok) to validate it

[sbdchd]

Yeah the api is pretty wonky at the moment, I'm working on a new parser that should make this easier when it's done!

preview of it at (using wasm):

https://tea.squawkhq.com

[johnmastro]

i think the failures in the python jobs are unrelated to these changes and instead related to sccache usage.

the final error reported is

💥 maturin failed
  Caused by: Cargo metadata failed. Does your crate compile with `cargo build`?
  Caused by: `cargo metadata` exited with an error: 

but it does compile with both cargo build and cargo build --release, and above that we have

error: process didn't exit successfully: `sccache /home/runner/.rustup/toolchains/1.84.0-x86_64-unknown-linux-gnu/bin/rustc -vV` (exit status: 2)
--- stderr
sccache: error: Server startup failed: cache storage failed to read: Unexpected (permanent) at read => {"$id":"1","innerException":null,"message":"This legacy service is shutting down, effective April 15, 2025. Migrate to the new service ASAP. For more information: https://gh.io/gha-cache-sunset","typeName":"Microsoft.Azure.DevOps.ArtifactCache.WebApi.ArtifactCacheServiceDecommissionedException, Microsoft.Azure.DevOps.ArtifactCache.WebApi","typeKey":"ArtifactCacheServiceDecommissionedException","errorCode":0,"eventId":3000}

[sbdchd]

Both of these docs are very thorough, thank you!

[sbdchd]

TIL domains are a thing! These rules are both great, thanks!