fix: support other 'booly' values for opts bool#493
Merged
kodiakhq[bot] merged 7 commits intosbdchd:masterfrom May 23, 2025
Merged
fix: support other 'booly' values for opts bool#493kodiakhq[bot] merged 7 commits intosbdchd:masterfrom
kodiakhq[bot] merged 7 commits intosbdchd:masterfrom
Conversation
👷 Deploy request for squawkhq pending review.Visit the deploys page to approve it
|
sbdchd
reviewed
May 23, 2025
| fn opt_bool_literal(p: &mut Parser<'_>) -> bool { | ||
| let m = p.start(); | ||
| if p.eat(TRUE_KW) || p.eat(FALSE_KW) { | ||
| // TOOD: we might want to check if its 1 or 0 specificially, not just `INT_NUMBER` |
Owner
There was a problem hiding this comment.
yeah we can add a validation for that in crates/squawk_syntax/src/validations.rs
which is layered on top of this, the parser doesn't know about actual values, so we can't really check here
sbdchd
approved these changes
May 23, 2025
Owner
|
Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up for #486
reference: https://www.postgresql.org/docs/current/sql-explain.html
makes 5 more regression tests pass 🎉
added one todo item - i was not sure if its possible to know if its specifically 1 or 0. let me know if it is! :)