Skip to content

fix: paren data source#497

Merged
kodiakhq[bot] merged 5 commits intosbdchd:masterfrom
psteinroe:fix/paren-data-source
May 24, 2025
Merged

fix: paren data source#497
kodiakhq[bot] merged 5 commits intosbdchd:masterfrom
psteinroe:fix/paren-data-source

Conversation

@psteinroe
Copy link
Contributor

@psteinroe psteinroe commented May 24, 2025

fixes data sources within parentheses. they can be either

  • a select statement
  • a join clause

this is now parsed properly:

select f1, count(*) from
  t1 x(x0,x1) left join (t1 left join t2 using(f1)) on (x0 = 0)

also uses column_list instead of tuple_expr for join using (…) nodes.

and added a little comment to the regression test to track how many are still failing.

@netlify
Copy link

netlify bot commented May 24, 2025

👷 Deploy request for squawkhq pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a0b1d25

Copy link
Owner

@sbdchd sbdchd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sbdchd sbdchd added the automerge automerge with kodiak label May 24, 2025
@kodiakhq kodiakhq bot merged commit 733e718 into sbdchd:master May 24, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge automerge with kodiak

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants