Merged
Conversation
👷 Deploy request for squawkhq pending review.Visit the deploys page to approve it
|
sbdchd
reviewed
May 24, 2025
| --- | ||
| source: crates/squawk_parser/tests/tests.rs | ||
| input_file: crates/squawk_parser/tests/data/ok/select.sql | ||
| snapshot_kind: text |
Owner
There was a problem hiding this comment.
I think if you upgrade cargo insta to a more recent version it stops including the snapshot_kind attr, but not 100% sure
When I run these locally it removes this attribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes parsing arg lists with modifiers such as
DISTINCT. before, additional args afterDISTINCTwere failing: