Skip to content

fix: agg modifiers#498

Merged
kodiakhq[bot] merged 5 commits intosbdchd:masterfrom
psteinroe:fix/agg-modifiers
May 24, 2025
Merged

fix: agg modifiers#498
kodiakhq[bot] merged 5 commits intosbdchd:masterfrom
psteinroe:fix/agg-modifiers

Conversation

@psteinroe
Copy link
Contributor

fixes parsing arg lists with modifiers such as DISTINCT. before, additional args after DISTINCT were failing:

select string_agg(distinct test, ',') from x;

@netlify
Copy link

netlify bot commented May 24, 2025

👷 Deploy request for squawkhq pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5349338

---
source: crates/squawk_parser/tests/tests.rs
input_file: crates/squawk_parser/tests/data/ok/select.sql
snapshot_kind: text
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you upgrade cargo insta to a more recent version it stops including the snapshot_kind attr, but not 100% sure

When I run these locally it removes this attribute

Copy link
Owner

@sbdchd sbdchd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sbdchd sbdchd added the automerge automerge with kodiak label May 24, 2025
@kodiakhq kodiakhq bot merged commit da00abe into sbdchd:master May 24, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge automerge with kodiak

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants