Skip to content

playground: bump react to 19 #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Oct 2, 2025
Merged

playground: bump react to 19 #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3159d13
playground: bump react to 19
sbdchd Oct 2, 2025
d6c586c
Merge branch 'master' into steved-bump-react
kodiakhq[bot] Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions playground/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,18 @@
"lz-string": "^1.5.0",
"monaco-editor": "^0.52.2",
"prettier": "^3.6.2",
"react": "^19.1.1",
"react-dom": "^19.1.1",
"react": "^19.2.0",
"react-dom": "^19.2.0",
"tailwindcss": "^4.1.12"
},
"devDependencies": {
"@eslint/js": "^9.34.0",
"@types/react": "^19.1.12",
"@types/react-dom": "^19.1.9",
"@types/react": "^19.2.0",
"@types/react-dom": "^19.2.0",
"@vitejs/plugin-react": "^4.7.0",
"babel-plugin-react-compiler": "19.1.0-rc.1",
"babel-plugin-react-compiler": "19.1.0-rc.3",
"eslint": "^9.34.0",
"eslint-plugin-react-hooks": "6.0.0-rc1",
"eslint-plugin-react-hooks": "6.1.0",
"eslint-plugin-react-refresh": "^0.4.20",
"globals": "^15.15.0",
"typescript": "~5.7.3",
Expand Down
91 changes: 46 additions & 45 deletions playground/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 16 additions & 14 deletions playground/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
import { useState, useEffect, useLayoutEffect, useRef } from "react"
import {
useState,
useEffect,
useLayoutEffect,
useRef,
useEffectEvent,
} from "react"
import * as monaco from "monaco-editor"
import { LintError, Fix, useDumpCst, useDumpTokens, useErrors } from "./squawk"
import {
Expand Down Expand Up @@ -233,22 +239,18 @@ function Editor({
settings: monaco.editor.IStandaloneEditorConstructionOptions
markers?: Marker[]
}) {
const onChangeRef = useRef<((_: string) => void) | undefined>(null)
const onSaveRef = useRef<((_: string) => void) | undefined>(null)
const onChangeText = useEffectEvent((text: string) => {
onChange?.(text)
})
const onSaveText = useEffectEvent((text: string) => {
onSave?.(text)
})
const divRef = useRef<HTMLDivElement>(null)
const autoFocusRef = useRef(autoFocus)
const settingsInitial = useRef(settings)
const editorRef = useRef<monaco.editor.IStandaloneCodeEditor>(null)
const fixesRef = useRef<Map<string, Fix>>(new Map())

// TODO: replace with useEventEffect
useEffect(() => {
onChangeRef.current = onChange
}, [onChange])
useEffect(() => {
onSaveRef.current = onSave
}, [onSave])

useEffect(() => {
if (markers == null) {
return
Expand All @@ -275,10 +277,10 @@ function Editor({
settingsInitial.current,
)
editor.addCommand(monaco.KeyMod.CtrlCmd | monaco.KeyCode.KeyS, () =>
onSaveRef.current?.(editor.getValue()),
onSaveText(editor.getValue()),
)
editor.onDidBlurEditorText(() => {
onSaveRef.current?.(editor.getValue())
onSaveText(editor.getValue())
})
monaco.languages.register({ id: "rast" })
const tokenProvider = monaco.languages.setMonarchTokensProvider("rast", {
Expand Down Expand Up @@ -346,7 +348,7 @@ function Editor({
)

editor.onDidChangeModelContent(() => {
onChangeRef.current?.(editor.getValue())
onChangeText(editor.getValue())
})
if (autoFocusRef.current) {
editor.focus()
Expand Down
Loading