Merged
Conversation
Right how we handle the various configuration knobs is a mess. We basically need to resolve the cli options and the file options into structs for each of the possible commands to execute. The enum for the github actions is nice, but gets a little messy here. We're also missing parity between the file config and the cli options. Some options are in the cli but not in the file. There's a lot of room for improvement. I want to get this sorted to make #679 easier to fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right how we handle the various configuration knobs is a mess.
We basically need to resolve the cli options and the file options into structs for each of the possible commands to execute.
The enum for the github actions is nice, but gets a little messy here.
We're also missing parity between the file config and the cli options. Some options are in the cli but not in the file.
There's a lot of room for improvement.
I want to get this sorted to make #679 easier to fix.