Skip to content

ide: goto def truncate, lock, vacuum, alter table column, refresh #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Jan 4, 2026
Merged

ide: goto def truncate, lock, vacuum, alter table column, refresh #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2003099
ide: goto def truncate, lock, vacuum, alter table column, refresh
sbdchd Jan 4, 2026
ac6435d
fix tests
sbdchd Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions crates/squawk_ide/src/classify.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,17 @@ pub(crate) enum NameRefClass {
JoinUsingColumn,
SchemaQualifier,
TypeReference,
TruncateTable,
LockTable,
VacuumTable,
AlterTable,
AlterTableColumn,
RefreshMaterializedView,
ReindexTable,
ReindexIndex,
ReindexSchema,
ReindexDatabase,
ReindexSystem,
}

pub(crate) fn classify_name_ref(name_ref: &ast::NameRef) -> Option<NameRefClass> {
Expand Down Expand Up @@ -192,6 +203,41 @@ pub(crate) fn classify_name_ref(name_ref: &ast::NameRef) -> Option<NameRefClass>
if ast::DropTable::can_cast(ancestor.kind()) {
return Some(NameRefClass::DropTable);
}
if ast::Truncate::can_cast(ancestor.kind()) {
return Some(NameRefClass::TruncateTable);
}
if ast::Lock::can_cast(ancestor.kind()) {
return Some(NameRefClass::LockTable);
}
if ast::Vacuum::can_cast(ancestor.kind()) {
return Some(NameRefClass::VacuumTable);
}
if ast::AlterColumn::can_cast(ancestor.kind()) {
return Some(NameRefClass::AlterTableColumn);
}
if ast::AlterTable::can_cast(ancestor.kind()) {
return Some(NameRefClass::AlterTable);
}
if ast::Refresh::can_cast(ancestor.kind()) {
return Some(NameRefClass::RefreshMaterializedView);
}
if let Some(reindex) = ast::Reindex::cast(ancestor.clone()) {
if reindex.table_token().is_some() {
return Some(NameRefClass::ReindexTable);
}
if reindex.index_token().is_some() {
return Some(NameRefClass::ReindexIndex);
}
if reindex.schema_token().is_some() {
return Some(NameRefClass::ReindexSchema);
}
if reindex.database_token().is_some() {
return Some(NameRefClass::ReindexDatabase);
}
if reindex.system_token().is_some() {
return Some(NameRefClass::ReindexSystem);
}
}
if ast::Table::can_cast(ancestor.kind()) {
return Some(NameRefClass::Table);
}
Expand Down
256 changes: 256 additions & 0 deletions crates/squawk_ide/src/goto_definition.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4780,4 +4780,260 @@ update users set email = new_data.column2$0 from new_data where users.id = new_d
╰╴ ─ 1. source
");
}

#[test]
fn goto_truncate_table() {
assert_snapshot!(goto("
create table t();
truncate table t$0;
"), @r"
╭▸
2 │ create table t();
│ ─ 2. destination
3 │ truncate table t;
╰╴ ─ 1. source
");
}

#[test]
fn goto_truncate_table_without_table_keyword() {
assert_snapshot!(goto("
create table t();
truncate t$0;
"), @r"
╭▸
2 │ create table t();
│ ─ 2. destination
3 │ truncate t;
╰╴ ─ 1. source
");
}

#[test]
fn goto_truncate_multiple_tables() {
assert_snapshot!(goto("
create table t1();
create table t2();
truncate t1, t2$0;
"), @r"
╭▸
3 │ create table t2();
│ ── 2. destination
4 │ truncate t1, t2;
╰╴ ─ 1. source
");
}

#[test]
fn goto_lock_table() {
assert_snapshot!(goto("
create table t();
lock table t$0;
"), @r"
╭▸
2 │ create table t();
│ ─ 2. destination
3 │ lock table t;
╰╴ ─ 1. source
");
}

#[test]
fn goto_lock_table_without_table_keyword() {
assert_snapshot!(goto("
create table t();
lock t$0;
"), @r"
╭▸
2 │ create table t();
│ ─ 2. destination
3 │ lock t;
╰╴ ─ 1. source
");
}

#[test]
fn goto_lock_multiple_tables() {
assert_snapshot!(goto("
create table t1();
create table t2();
lock t1, t2$0;
"), @r"
╭▸
3 │ create table t2();
│ ── 2. destination
4 │ lock t1, t2;
╰╴ ─ 1. source
");
}

#[test]
fn goto_vacuum_table() {
assert_snapshot!(goto("
create table users(id int, email text);
vacuum users$0;
"), @r"
╭▸
2 │ create table users(id int, email text);
│ ───── 2. destination
3 │ vacuum users;
╰╴ ─ 1. source
");
}

#[test]
fn goto_vacuum_multiple_tables() {
assert_snapshot!(goto("
create table t1();
create table t2();
vacuum t1, t2$0;
"), @r"
╭▸
3 │ create table t2();
│ ── 2. destination
4 │ vacuum t1, t2;
╰╴ ─ 1. source
");
}

#[test]
fn goto_alter_table() {
assert_snapshot!(goto("
create table users(id int, email text);
alter table users$0 alter email set not null;
"), @r"
╭▸
2 │ create table users(id int, email text);
│ ───── 2. destination
3 │ alter table users alter email set not null;
╰╴ ─ 1. source
");
}

#[test]
fn goto_alter_table_column() {
assert_snapshot!(goto("
create table users(id int, email text);
alter table users alter email$0 set not null;
"), @r"
╭▸
2 │ create table users(id int, email text);
│ ───── 2. destination
3 │ alter table users alter email set not null;
╰╴ ─ 1. source
");
}

#[test]
fn goto_alter_table_column_with_column_keyword() {
assert_snapshot!(goto("
create table users(id int, email text);
alter table users alter column email$0 set not null;
"), @r"
╭▸
2 │ create table users(id int, email text);
│ ───── 2. destination
3 │ alter table users alter column email set not null;
╰╴ ─ 1. source
");
}

#[test]
fn goto_refresh_materialized_view() {
assert_snapshot!(goto("
create materialized view mv as select 1;
refresh materialized view mv$0;
"), @r"
╭▸
2 │ create materialized view mv as select 1;
│ ── 2. destination
3 │ refresh materialized view mv;
╰╴ ─ 1. source
");
}

#[test]
fn goto_refresh_materialized_view_concurrently() {
assert_snapshot!(goto("
create materialized view mv as select 1;
refresh materialized view concurrently mv$0;
"), @r"
╭▸
2 │ create materialized view mv as select 1;
│ ── 2. destination
3 │ refresh materialized view concurrently mv;
╰╴ ─ 1. source
");
}

#[test]
fn goto_reindex_table() {
assert_snapshot!(goto("
create table users(id int);
reindex table users$0;
"), @r"
╭▸
2 │ create table users(id int);
│ ───── 2. destination
3 │ reindex table users;
╰╴ ─ 1. source
");
}

#[test]
fn goto_reindex_index() {
assert_snapshot!(goto("
create table t(c int);
create index idx on t(c);
reindex index idx$0;
"), @r"
╭▸
3 │ create index idx on t(c);
│ ─── 2. destination
4 │ reindex index idx;
╰╴ ─ 1. source
");
}

#[test]
fn goto_reindex_schema() {
assert_snapshot!(goto("
create schema app;
reindex schema app$0;
"), @r"
╭▸
2 │ create schema app;
│ ─── 2. destination
3 │ reindex schema app;
╰╴ ─ 1. source
");
}

#[test]
fn goto_reindex_database() {
assert_snapshot!(goto("
create database appdb;
reindex database appdb$0;
"), @r"
╭▸
2 │ create database appdb;
│ ───── 2. destination
3 │ reindex database appdb;
╰╴ ─ 1. source
");
}

#[test]
fn goto_reindex_system() {
assert_snapshot!(goto("
create database systemdb;
reindex system systemdb$0;
"), @r"
╭▸
2 │ create database systemdb;
│ ──────── 2. destination
3 │ reindex system systemdb;
╰╴ ─ 1. source
");
}
}
Loading
Loading