Skip to content

ide: support select-to-values action in more places #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Jan 14, 2026
Merged

ide: support select-to-values action in more places #847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions crates/squawk_ide/src/code_actions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,12 +662,13 @@ fn rewrite_select_as_values(

fn find_select_parent(token: SyntaxToken) -> Option<SelectContext> {
let mut found_select = None;
let mut found_compound = None;
for node in token.parent_ancestors() {
if let Some(compound_select) = ast::CompoundSelect::cast(node.clone()) {
if compound_select.union_token().is_some() && compound_select.all_token().is_some() {
return Some(SelectContext::Compound(compound_select));
found_compound = Some(SelectContext::Compound(compound_select));
} else {
return None;
break;
}
}
if found_select.is_none()
Expand All @@ -676,7 +677,7 @@ fn find_select_parent(token: SyntaxToken) -> Option<SelectContext> {
found_select = Some(SelectContext::Single(select));
}
}
found_select
found_compound.or(found_select)
}

#[cfg(test)]
Expand Down Expand Up @@ -1631,6 +1632,17 @@ mod test {
);
}

#[test]
fn rewrite_select_as_values_multiple_rows_cursor_on_second_union() {
assert_snapshot!(
apply_code_action(
rewrite_select_as_values,
"select 1 as column1, 2 as column2 union all select 3, 4 union$0 all select 5, 6;"
),
@"values (1, 2), (3, 4), (5, 6);"
);
}

#[test]
fn rewrite_select_as_values_single_column() {
assert_snapshot!(
Expand Down
Loading