Skip to content

linter: don't report lint errors when syntax error found #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Feb 21, 2026
Merged

linter: don't report lint errors when syntax error found #943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 60 additions & 39 deletions crates/squawk/src/reporter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,49 +33,61 @@ fn check_sql(
linter.settings.assume_in_transaction = assume_in_transaction;
let parse = SourceFile::parse(sql);
let parse_errors = parse.errors();
let errors = linter.lint(&parse, sql);
let line_index = LineIndex::new(sql);

let mut violations = Vec::with_capacity(parse_errors.len() + errors.len());

for e in parse_errors {
let range_start = e.range().start();
let line_col = line_index.line_col(range_start);
let range_end = e.range().end();
let line_end = line_index.line_col(range_end);
violations.push(ReportViolation {
file: path.to_string(),
line: line_col.line as usize,
line_end: line_end.line as usize,
column: line_col.col as usize,
column_end: line_end.col as usize,
level: ViolationLevel::Error,
help: None,
range: e.range(),
message: e.message().to_string(),
rule_name: "syntax-error".to_string(),
fix: None,
})
if !parse_errors.is_empty() {
let violations = parse_errors
.into_iter()
.map(|e| {
let range_start = e.range().start();
let line_col = line_index.line_col(range_start);
let range_end = e.range().end();
let line_end = line_index.line_col(range_end);
ReportViolation {
file: path.to_string(),
line: line_col.line as usize,
line_end: line_end.line as usize,
column: line_col.col as usize,
column_end: line_end.col as usize,
level: ViolationLevel::Error,
help: None,
range: e.range(),
message: e.message().to_string(),
rule_name: "syntax-error".to_string(),
fix: None,
}
})
.collect();
return CheckReport {
filename: path.into(),
sql: sql.into(),
violations,
};
}
for e in errors {
let range_start = e.text_range.start();
let line_col = line_index.line_col(range_start);
let range_end = e.text_range.end();
let line_end = line_index.line_col(range_end);
violations.push(ReportViolation {
file: path.to_string(),
line: line_col.line as usize,
line_end: line_end.line as usize,
column: line_col.col as usize,
column_end: line_end.col as usize,
range: e.text_range,
help: e.help,
level: ViolationLevel::Warning,
message: e.message,
rule_name: e.code.to_string(),
fix: e.fix,

let errors = linter.lint(&parse, sql);
let violations = errors
.into_iter()
.map(|e| {
let range_start = e.text_range.start();
let line_col = line_index.line_col(range_start);
let range_end = e.text_range.end();
let line_end = line_index.line_col(range_end);
ReportViolation {
file: path.to_string(),
line: line_col.line as usize,
line_end: line_end.line as usize,
column: line_col.col as usize,
column_end: line_end.col as usize,
range: e.text_range,
help: e.help,
level: ViolationLevel::Warning,
message: e.message,
rule_name: e.code.to_string(),
fix: e.fix,
}
})
}
.collect();

CheckReport {
filename: path.into(),
Expand Down Expand Up @@ -485,6 +497,15 @@ select \;
let val: Value = serde_json::from_slice(&buff).unwrap();
assert_snapshot!(val);
}

#[test]
fn skip_lint_on_syntax_error() {
let error_sql = "ALTER TABLE foo ALTER CONSTRAINT bar RENAME TO quux;";
let mut buff = vec![];
let res = check_sql(error_sql, "test.sql", &[], None, false);
fmt_json(&mut buff, vec![res]).unwrap();
assert_snapshot!(String::from_utf8_lossy(&buff), @r#"[{"file":"test.sql","line":0,"column":36,"level":"Error","message":"missing comma","help":null,"rule_name":"syntax-error","column_end":36,"line_end":0}]"#);
}
}

#[cfg(test)]
Expand Down
Loading