fix: resolve pyright type checking errors in lc2st.py#1776
Closed
mhusnain-tech wants to merge 1 commit intosbi-dev:mainfrom
Closed
fix: resolve pyright type checking errors in lc2st.py#1776mhusnain-tech wants to merge 1 commit intosbi-dev:mainfrom
mhusnain-tech wants to merge 1 commit intosbi-dev:mainfrom
Conversation
This commit fixes the "float is not iterable" error in the eval_lc2st function. The list multiplication [0.5] * len(proba) was replaced with a direct subtraction (proba - 0.5) to utilize NumPy's broadcasting. This resolves the type ambiguity for Pyright and improves code efficiency.
Contributor
|
Hi @mhusnain-tech , Please adhere to our contribution guidelines and discuss PR via issues before opening them. This problem has been fixed already in the recent PR #1774 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the "float is not iterable" error in the eval_lc2st function. The list multiplication [0.5] * len(proba) was replaced with a direct subtraction (proba - 0.5) to utilize NumPy's broadcasting. This resolves the type ambiguity for Pyright and improves code efficiency.