Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1777 +/- ##
==========================================
+ Coverage 87.65% 87.77% +0.12%
==========================================
Files 140 140
Lines 12178 12224 +46
==========================================
+ Hits 10675 10730 +55
+ Misses 1503 1494 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
manuelgloeckler
left a comment
There was a problem hiding this comment.
Great, makes sense to change this!
I think one can do a few changes (see comments), especially I would adapt the downstream code to now actually use the introduced dataclass instead of the kwargs.
manuelgloeckler
left a comment
There was a problem hiding this comment.
Great!
Maybe it is already an issue, but I feel like a it would make sense to rewrite all the factories like this (i.e. replace the kwargs with dataclasses internally) so maybe makes sense to add an issue for that.
fixing kwargs issues in VF methods and adds a couple of edge case fixes for the time schedules.
See #1775 for context
closing #1775
Note: I introduce a new config dataclass for all VF parameters. it is used only internally and basically only for validating user-passed args and raising errors on typos or unknown args. Alternatively, we could do this manually by defining a dict or sequence of known args for each option, but I like the dataclass approach better and we could eventually use it a public config at a later point.