Skip to content

Support the new API GetObjectAttributes#2588

Open
maeldonn wants to merge 5 commits intodevelopment/8.3from
feature/ARSN-549/get-object-attributes
Open

Support the new API GetObjectAttributes#2588
maeldonn wants to merge 5 commits intodevelopment/8.3from
feature/ARSN-549/get-object-attributes

Conversation

@maeldonn
Copy link

Issue: ARSN-549

@maeldonn maeldonn requested review from a team, DarkIsDude, Copilot and delthas January 26, 2026 08:59
@bert-e
Copy link
Contributor

bert-e commented Jan 26, 2026

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jan 26, 2026

Incorrect fix version

The Fix Version/s in issue ARSN-549 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.2.44

  • 8.3.0

Please check the Fix Version/s of ARSN-549, or the target
branch of this pull request.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the AWS S3 GetObjectAttributes API by introducing routing logic, action mappings, and incrementing the package version.

Changes:

  • Added routing for the objectGetAttributes API method triggered by the attributes query parameter
  • Added action mappings for objectGetAttributes in both policy evaluation and monitoring maps
  • Incremented package version from 8.2.43 to 8.2.44

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
package.json Bumped version to 8.2.44 for the new API support
lib/s3routes/routes/routeGET.ts Added routing logic to handle query.attributes parameter and call objectGetAttributes
lib/policyEvaluator/utils/actionMaps.ts Added objectGetAttributes to both sharedActionMap and actionMonitoringMapS3 for IAM policy evaluation and monitoring

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@DarkIsDude DarkIsDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No a lot to add, IA spotted them

@bert-e
Copy link
Contributor

bert-e commented Jan 26, 2026

Incorrect fix version

The Fix Version/s in issue ARSN-549 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.2.44

  • 8.3.1

Please check the Fix Version/s of ARSN-549, or the target
branch of this pull request.

Copy link

@delthas delthas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from AI comments

Copy link
Contributor

@francoisferrand francoisferrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments from Copilot

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.75%. Comparing base (c448c35) to head (f6f4171).

Additional details and impacted files
@@               Coverage Diff                @@
##           development/8.3    #2588   +/-   ##
================================================
  Coverage            72.75%   72.75%           
================================================
  Files                  221      221           
  Lines                18082    18085    +3     
  Branches              3764     3765    +1     
================================================
+ Hits                 13155    13158    +3     
  Misses                4922     4922           
  Partials                 5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maeldonn maeldonn force-pushed the feature/ARSN-549/get-object-attributes branch from 4040f77 to ec21fa8 Compare January 28, 2026 09:31
@maeldonn maeldonn force-pushed the feature/ARSN-549/get-object-attributes branch from ec21fa8 to ed5970c Compare February 2, 2026 15:48
@maeldonn maeldonn changed the base branch from development/8.2 to feature/ARSN-544/list-objects-v2-optional-attributes February 2, 2026 15:49
@maeldonn maeldonn force-pushed the feature/ARSN-549/get-object-attributes branch from d3d5fe5 to 46757d4 Compare February 4, 2026 06:19
Base automatically changed from feature/ARSN-544/list-objects-v2-optional-attributes to development/8.2 February 4, 2026 11:10
@maeldonn maeldonn force-pushed the feature/ARSN-549/get-object-attributes branch from 46757d4 to f02179a Compare February 4, 2026 15:45
@bert-e
Copy link
Contributor

bert-e commented Feb 4, 2026

Incorrect fix version

The Fix Version/s in issue ARSN-549 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.2.45

  • 8.3.2

Please check the Fix Version/s of ARSN-549, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2026

Incorrect fix version

The Fix Version/s in issue ARSN-549 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.2.45

  • 8.3.2

Please check the Fix Version/s of ARSN-549, or the target
branch of this pull request.

@scality scality deleted a comment from bert-e Feb 10, 2026
@bert-e
Copy link
Contributor

bert-e commented Feb 12, 2026

Incorrect fix version

The Fix Version/s in issue ARSN-549 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.2.46

  • 8.3.3

Please check the Fix Version/s of ARSN-549, or the target
branch of this pull request.

@maeldonn maeldonn force-pushed the feature/ARSN-549/get-object-attributes branch from 475f746 to 2f870db Compare February 12, 2026 14:03
@maeldonn maeldonn changed the base branch from development/8.2 to development/8.3 February 12, 2026 14:03
@bert-e
Copy link
Contributor

bert-e commented Feb 12, 2026

Incorrect fix version

The Fix Version/s in issue ARSN-549 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.3.3

Please check the Fix Version/s of ARSN-549, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Feb 12, 2026

Incorrect fix version

The Fix Version/s in issue ARSN-549 contains:

  • 8.3.2

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.3.3

Please check the Fix Version/s of ARSN-549, or the target
branch of this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants