Support the new API GetObjectAttributes#2588
Support the new API GetObjectAttributes#2588maeldonn wants to merge 5 commits intodevelopment/8.3from
Conversation
Hello maeldonn,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
There was a problem hiding this comment.
Pull request overview
This PR adds support for the AWS S3 GetObjectAttributes API by introducing routing logic, action mappings, and incrementing the package version.
Changes:
- Added routing for the
objectGetAttributesAPI method triggered by theattributesquery parameter - Added action mappings for
objectGetAttributesin both policy evaluation and monitoring maps - Incremented package version from 8.2.43 to 8.2.44
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Bumped version to 8.2.44 for the new API support |
| lib/s3routes/routes/routeGET.ts | Added routing logic to handle query.attributes parameter and call objectGetAttributes |
| lib/policyEvaluator/utils/actionMaps.ts | Added objectGetAttributes to both sharedActionMap and actionMonitoringMapS3 for IAM policy evaluation and monitoring |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DarkIsDude
left a comment
There was a problem hiding this comment.
No a lot to add, IA spotted them
francoisferrand
left a comment
There was a problem hiding this comment.
see comments from Copilot
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/8.3 #2588 +/- ##
================================================
Coverage 72.75% 72.75%
================================================
Files 221 221
Lines 18082 18085 +3
Branches 3764 3765 +1
================================================
+ Hits 13155 13158 +3
Misses 4922 4922
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4040f77 to
ec21fa8
Compare
ec21fa8 to
ed5970c
Compare
d3d5fe5 to
46757d4
Compare
46757d4 to
f02179a
Compare
475f746 to
2f870db
Compare
Issue: ARSN-549