Skip to content

ARSN-551: don't require x-amz-content-sha256 header to be signed#2590

Merged
bert-e merged 2 commits intodevelopment/8.2from
bugfix/ARSN-551-dont-require-x-amz-content-sha256-signed
Feb 11, 2026
Merged

ARSN-551: don't require x-amz-content-sha256 header to be signed#2590
bert-e merged 2 commits intodevelopment/8.2from
bugfix/ARSN-551-dont-require-x-amz-content-sha256-signed

Conversation

@leif-scality
Copy link
Contributor

In practice AWS does not require x-amz-content-sha256 to be signed. So we remove the requirement

@bert-e
Copy link
Contributor

bert-e commented Feb 9, 2026

Hello leif-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

1 similar comment
@bert-e
Copy link
Contributor

bert-e commented Feb 9, 2026

Hello leif-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 9, 2026

Temporary base failure

I've had trouble contacting the git host. Just post a comment on this pull request to wake me up.

@bert-e
Copy link
Contributor

bert-e commented Feb 9, 2026

Incorrect fix version

The Fix Version/s in issue ARSN-551 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.2.45

  • 8.3.2

Please check the Fix Version/s of ARSN-551, or the target
branch of this pull request.

1 similar comment
@bert-e
Copy link
Contributor

bert-e commented Feb 9, 2026

Incorrect fix version

The Fix Version/s in issue ARSN-551 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.2.45

  • 8.3.2

Please check the Fix Version/s of ARSN-551, or the target
branch of this pull request.

@leif-scality leif-scality force-pushed the bugfix/ARSN-551-dont-require-x-amz-content-sha256-signed branch from cdebd75 to 024d5e4 Compare February 9, 2026 16:19
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.41%. Comparing base (960e770) to head (af610f2).
⚠️ Report is 2 commits behind head on development/8.2.

Additional details and impacted files
@@               Coverage Diff                @@
##           development/8.2    #2590   +/-   ##
================================================
  Coverage            71.41%   71.41%           
================================================
  Files                  222      222           
  Lines                17916    17918    +2     
  Branches              3703     3728   +25     
================================================
+ Hits                 12795    12797    +2     
  Misses                5117     5117           
  Partials                 4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leif-scality leif-scality force-pushed the bugfix/ARSN-551-dont-require-x-amz-content-sha256-signed branch from 1b97f42 to 8e40c35 Compare February 10, 2026 10:38
@leif-scality leif-scality force-pushed the bugfix/ARSN-551-dont-require-x-amz-content-sha256-signed branch from 8e40c35 to af610f2 Compare February 10, 2026 10:39
@leif-scality
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@leif-scality
Copy link
Contributor Author

/create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Feb 11, 2026

Conflict

A conflict has been raised during the creation of
integration branch w/8.3/bugfix/ARSN-551-dont-require-x-amz-content-sha256-signed with contents from bugfix/ARSN-551-dont-require-x-amz-content-sha256-signed
and development/8.3.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/8.3/bugfix/ARSN-551-dont-require-x-amz-content-sha256-signed origin/development/8.3
 git merge origin/bugfix/ARSN-551-dont-require-x-amz-content-sha256-signed
 # <intense conflict resolution>
 git commit
 git push -u origin w/8.3/bugfix/ARSN-551-dont-require-x-amz-content-sha256-signed

The following options are set: create_integration_branches

@leif-scality
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented Feb 11, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@leif-scality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Feb 11, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.2

  • ✔️ development/8.3

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1

Please check the status of the associated issue ARSN-551.

Goodbye leif-scality.

The following options are set: approve, create_integration_branches

@bert-e bert-e merged commit af610f2 into development/8.2 Feb 11, 2026
7 checks passed
@bert-e bert-e deleted the bugfix/ARSN-551-dont-require-x-amz-content-sha256-signed branch February 11, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants