-
Notifications
You must be signed in to change notification settings - Fork 2
chore:SP-3893 upgrade dependencies #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughBumped project version from 0.12.0 to 0.12.1 and updated multiple dependency versions (slf4j, commons-codec, tika-core, gson, picocli, lombok, org.eclipse.jgit). Added a new 0.12.1 entry to CHANGELOG.md and updated release link references. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @pom.xml:
- Line 75: You bumped tika-core to 3.2.2 which has breaking changes; update
build and tests to target Java 11+ (adjust maven-compiler-plugin/source & target
or project toolchain), run and fix integration tests exercising Tika usage (look
for references to Tika, MediaType, MediaTypeRegistry), and validate/adjust
behavior for HTML parsing (TagSoup→JSoup), custom-mimetypes classpath lookup,
and MIME mapping changes (e.g., JavaScript → text/javascript); if your code
relied on Xerces or Boilerpipe classes add explicit dependencies (xercesImpl or
the new boilerpipe package) or refactor usages to the new APIs, and add explicit
tests that assert detected MIME types and parsed HTML output to lock expected
behavior under 3.2.2.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.mdpom.xml
🔇 Additional comments (4)
CHANGELOG.md (2)
13-21: LGTM! Changelog documentation is accurate.The changelog entry correctly documents all seven dependency updates and follows the Keep a Changelog format consistently.
143-144: LGTM! Version link references are correct.The link references have been properly updated to reflect the new 0.12.1 release.
pom.xml (2)
9-9: LGTM! Version bump is appropriate.The project version bump from 0.12.0 to 0.12.1 is appropriate for a dependency update release.
41-41: Dependency versions verified and confirmed secure.All updated dependencies have been checked against NVD and security advisories. No known CVEs affect these versions:
- slf4j 2.0.17: No upstream CVE
- commons-codec 1.20.0: Safe (Base32 issue fixed in 1.14+)
- tika-core 3.2.2: Fixed for XXE vulnerabilities (CVE-2025-54988, CVE-2025-66516)
- gson 2.13.2: Safe
- picocli 4.7.7: No known CVE
- lombok 1.18.42: No known CVE
- jgit 6.10.1: Fixed for XXE vulnerability (CVE-2025-4949)
- okhttp 4.12.0: No known CVE
The project has appropriately updated to patched versions for recent critical vulnerabilities.
6469b42 to
3cca36f
Compare
What's Changed
Changed
Fix: #35
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.