[FIX] #156 Browser complains about mixed content#159
Open
darylteo wants to merge 3 commits intoscaron:masterfrom
Open
[FIX] #156 Browser complains about mixed content#159darylteo wants to merge 3 commits intoscaron:masterfrom
darylteo wants to merge 3 commits intoscaron:masterfrom
Conversation
If a site is loaded using https:// youtube videos (and probably other embeds) will not load because the script hard codes http in the video URLs The following fix is as follows: - only applies to video urls (any impact on other embeds unknown) - checks for the current document protocol (http: or https:) - if protocol is file:, then it defaults to http: as is existing behaviour See this fix in action at by clicking the vimeo videos on the right. https://www.listcorp.com/asx/ler
Set property to true in settings.
Author
|
This PR now supports the allowfullscreen property. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Issue
If a site is loaded using https:// youtube videos (and probably
other embeds) will not load because the script hard codes http
in the video URLs
The following fix is as follows:
See this fix in action
here
and by clicking the vimeo videos on the right sidebar