Open
Conversation
Contributor
Author
|
Ping. |
schezfaz
reviewed
Nov 6, 2020
| }); | ||
| }); | ||
| }); | ||
| } |
Owner
There was a problem hiding this comment.
This is a smart workaround! However, I have been working on this simultaneously on my local, instead of opening this pop-up, what I figured we could do was:
- Highlight text on webpage --> Right click --> Open context menu --> Select SPOT
- We'll send just the data that was highlighted to the extension, probably trigger a notification on the bottom right corner (not sure if this is feasible - but looking into it)
- User will manually open the SPOT extension
- Search results of most recent highlighted text should be present
does this make sense?
I'll push these changes to a new branch, and have you review them if you'd like. Post which we can figure what is the most optimum way of proceeding with this functionality!
Contributor
Author
There was a problem hiding this comment.
Absolutely, the notification idea sounds great. The new window was making the css quite grotesque anyway.
Owner
There was a problem hiding this comment.
Truu haha, will push to the new branch in a bit and ping you for a review!!
Owner
Apologies haha, busy week at work! |
Add config file for credentials
Revert "Add config file for credentials"
Search Functionality Tweaks
Fetch & Query the song from current youtube tab
…nd-spot-it Context menu to highlight text and spot it
Added liked songs to the final playlist view!
func. to filter playlists based on input search keyword
grid layout for playlists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've theoretically been able to add a context menu.
You can now highlight a word and search with spot.
Current issues:
It simply opens the popup, doesn't really searchSearch functionality added in 6fd092fhttps://stackoverflow.com/questions/13783500/context-menus-in-chrome-extensions