[FIX] Allow fallback file to work when passing in multiple root directories#8
Open
jackp wants to merge 2 commits intoschickling:masterfrom
Open
[FIX] Allow fallback file to work when passing in multiple root directories#8jackp wants to merge 2 commits intoschickling:masterfrom
jackp wants to merge 2 commits intoschickling:masterfrom
Conversation
added 2 commits
July 15, 2014 22:36
If passing in multiple root directories, the fallback file gets set after each directory is served, therefore never reaching the additional directories.
Author
|
This feature is working fine for me, but I'm having trouble getting the test to pass |
Owner
|
Thanks @jackp for your PR. Please fix the tests, I want to keep the CI env healthy 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the fallback file gets set after every directory is served, the request will never be able to hit any subsequent directories.
This PR sets the fallback files at the end of the stream, therefore allowing users to use