-
Notifications
You must be signed in to change notification settings - Fork 260
ci: Removing travis-ci #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @gsnw-sebast, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's continuous integration setup by completely removing the Travis CI configuration. This change is driven by the fact that Travis CI is no longer actively utilized for the project and its free tier for open-source initiatives has been discontinued. The project's changelog has also been updated to reflect this significant infrastructure modification. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes the .travis.yml configuration file, as Travis CI is no longer used by the project. The update to CHANGELOG.md is also appropriate.
However, the removal of Travis CI integration appears to be incomplete. I've noticed a few files and code snippets related to Travis CI that are now obsolete and should probably be removed to complete the cleanup:
ci/deploy-coveralls.sh: This script uses Travis CI environment variables likeTRAVIS_DISTandTRAVIS_OS_NAME. It was triggered by.travis.ymland seems to be unused now.ci/deploy-coverity.sh: This script uses theTRAVIS_BUILD_IDenvironment variable and was also likely only used in the Travis CI pipeline.- In
ci/build-4-compile.sh, there is a comment## setcap currently doesn't work anymore on travis-ciwhich is now outdated.
I recommend expanding this PR to remove these leftover files and references. This will help improve the maintainability of the CI scripts.
b8f314f to
bf97066
Compare
bf97066 to
1ae0c36
Compare
|
I'm not sure, but do we need ci/deploy-coverity.sh or did that only running with travis-ci? |
I would keep that script. It probably can be ported to run using Github Actions. |
|
I fixed the coverity stuff (it now runs with GitHub Actions) |
Removing travis-ci because it is no longer actively used and travis-ci does not offer a free option for opensource projects