-
Notifications
You must be signed in to change notification settings - Fork 43
BUG: fix __doctest_requires__ when constraint is present #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
@pllim, Thank you for all your support. I took the PR out of draft. I noticed that you changed the milestone to 1.7.1. Do we need to change the first line of the changelog to 1.7.1 instead of 1.8.0? |
I think that is at the discretion of the release manager. I feel like this is a bug and should land in a bugfix release if the next release does not contain new feature. It is not something we should worry about in this PR. |
|
@bsipocz are you able to review the internal code changes or ping someone who can? Thanks! |
bsipocz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good, and I like that you added comprehensive case coverage for the test.
|
Thank you @KostaIlic2! |
@bsipocz, Thank you for the feedback! And thank you for your speedy responses and support! |
Fix #318.
Also improved related unit test.