Skip to content

Conversation

@KostaIlic2
Copy link
Contributor

Fix #318.

Also improved related unit test.

@pllim pllim requested a review from bsipocz January 21, 2026 21:48
KostaIlic2 and others added 2 commits January 22, 2026 14:37
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
@pllim

This comment was marked as resolved.

@KostaIlic2 KostaIlic2 marked this pull request as ready for review January 23, 2026 15:55
@KostaIlic2
Copy link
Contributor Author

Tests passed. Do you wish to take this out of draft? Thanks! :)

@pllim, Thank you for all your support. I took the PR out of draft.

I noticed that you changed the milestone to 1.7.1. Do we need to change the first line of the changelog to 1.7.1 instead of 1.8.0?

@pllim
Copy link
Contributor

pllim commented Jan 23, 2026

Do we need to change the first line of the changelog to 1.7.1 instead of 1.8.0?

I think that is at the discretion of the release manager. I feel like this is a bug and should land in a bugfix release if the next release does not contain new feature. It is not something we should worry about in this PR.

@pllim
Copy link
Contributor

pllim commented Jan 23, 2026

@bsipocz are you able to review the internal code changes or ping someone who can? Thanks!

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, and I like that you added comprehensive case coverage for the test.

@bsipocz
Copy link
Member

bsipocz commented Jan 26, 2026

Thank you @KostaIlic2!

@bsipocz bsipocz merged commit 44de19c into scientific-python:main Jan 26, 2026
15 checks passed
@KostaIlic2
Copy link
Contributor Author

This all looks good, and I like that you added comprehensive case coverage for the test.

@bsipocz, Thank you for the feedback! And thank you for your speedy responses and support!

@KostaIlic2 KostaIlic2 deleted the fix-issue-318 branch January 26, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests always skipped when dependency version is present

3 participants