New SBI models from anya #334
Conversation
| 'Transient MWEBV', | ||
| 'Host MWEBV', | ||
| 'Log transient processing status', | ||
| 'Local aperture photometry photo-z', |
There was a problem hiding this comment.
The migration scripts are immutable; they are an append-only stack. You'll need to move the creation of these three new tasks to 0037.
There was a problem hiding this comment.
Oh wait, I see that you already did this. Perhaps you just need to revert the change to 0024.
| x_train_local = pickle.load(handle) | ||
| x_train_zphot = pickle.load(handle) | ||
| print("""Training sets loaded.""") | ||
| except Exception as err: |
There was a problem hiding this comment.
What exactly is the failure mode you anticipate here? This seems too broad. Also, it looks like this block is executed upon import (which happens here), because it is not under a "if name=main" condition. Can this be done better?
There was a problem hiding this comment.
Conversation follow-up: This redundant pickle file loading code should be refactored into a function.
so that IDEs can resolve host.SBI.run_sbi_blast
app/host/transient_tasks.py
Outdated
| elif host.photometric_redshift is not None: | ||
| pass | ||
| elif transient.redshift is not None: | ||
| pass |
There was a problem hiding this comment.
What is the purpose of these pass statements?
There was a problem hiding this comment.
Conversation follow-up: These last two elif-pass statements are no longer useful with the else block removed.
Fixes # .
Description of the Change
New SBI models, redshift up to z = 1.5 and photo-z implemented.
Checklist
Please check all that apply to your proposed changes
Additional context