Skip to content

Conversation

@baltierra
Copy link
Collaborator

Added the secrets and variables to GitHub and created the .yml file to achieve automatic deployment. I added backup creation and rollbacks in case of deploy-failure. It also considers the correct backend deploy order given that frontend and backend share the same docker-compose network.

@baltierra baltierra requested a review from jnation3406 October 23, 2025 16:29
@coveralls
Copy link

coveralls commented Oct 23, 2025

Pull Request Test Coverage Report for Build 18950451090

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.172%

Totals Coverage Status
Change from base Build 18381357528: 0.0%
Covered Lines: 2840
Relevant Lines: 3115

💛 - Coveralls

Copy link
Collaborator

@jnation3406 jnation3406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks basically the same as the frontend PR I reviewed, so all the same comments I made on that one apply to this one as well.

- Use heredoc for SSH key and env file creation (more secure)
- Change production trigger from branch push to tag push
- Add version tracking with .deployed_version file
- Update backup/rollback to include version information

Addresses feedback from PR review.
@baltierra
Copy link
Collaborator Author

This looks basically the same as the frontend PR I reviewed, so all the same comments I made on that one apply to this one as well.

Thanks for the heads up I've updated the workflow to:

  • Use heredoc instead of echo for writing secrets
  • Changed production deployment to tag-based (no auto-deploy on main push)
  • Added version tracking for clearer rollbacks
  • GitHub logs are protected so should not leak.

Still working on the docker improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants