Draft
Conversation
Implement workflow using BifrostBraggPeakMonitorWorkflow from essspectroscopy to produce Q_parallel vs Q_perpendicular histograms from a Bragg peak monitor. Key implementation details: - BraggPeakAuxSources requires detector_rotation (a4) and sample_rotation (a3) since the monitor is mounted on the detector tank - Hard-coded EmptyDetector position (1m upstream of sample) until geometry exists in NeXus files - Directly uses assemble_detector_data to bypass McStas simulation chain (McStas wraps event_time_offset which is unnecessary for live data) - Custom _bragg_peak_monitor_ltotal for straight-line flight path approximation - Fake data generator configured for single-pixel detector Original prompt: "essspectroscopy recently added a new workflow that we need to use to implement a 'Bragg-peak monitor Q-map'. Can you find out which workflow that was, and which version of essspectroscopy we need?" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add exclude_from_merge parameter to Ev44ToDetectorEventsAdapter to allow specific detectors to bypass the unified_detector merging. For Bifrost, bragg_peak_monitor is excluded so it flows as a separate stream for the Bragg peak Q-map workflow. Original prompt: "I wonder if the Bifrost-detector-merging (special case configured in Kafka adapter) will get in the way here?" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready, need to iron out issues changing away from McStas workflow and wait for actual file to avoid working around lack of position info and transformation chain.