Open
Conversation
nvaytet
reviewed
Feb 2, 2026
pyproject.toml
Outdated
| "scippnexus>=25.06.0", | ||
| # Numba has an upper pin and pip-compile-multi will | ||
| # always complain about solving envs with different numpy pins. | ||
| "numpy<2.4", |
Member
There was a problem hiding this comment.
We should not have upper pins in the main dependencies.
We should try to find a different way of solving this issue.
Numba is not a core dependency, but is needed for the tests.
We could e.g. add the pin to the tests deps, instead of the main deps, or add a pin in the test.in file?
Member
Author
There was a problem hiding this comment.
I agree I don't like this setup either.
The problem is that pip-compile-multi does not care about the pyproject.toml file, it is solving envs from the requirements folder.
I can add this to base.in, but this adds another place to bump deps manually which I don't like much. But anyway pushed a new commit which should move the numpy pin out of pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #289 too.