Move the tof lookup table error threshold to the GenericTofWorkflow#313
Open
Move the tof lookup table error threshold to the GenericTofWorkflow#313
Conversation
nvaytet
commented
Feb 6, 2026
| "pulse_stride", | ||
| "distance_resolution", | ||
| "time_resolution", | ||
| "error_threshold", |
Member
Author
There was a problem hiding this comment.
Note that the table may or may not have a error_threshold coord. If it does not, trying to remove it using drop_coords would raise. So we filter it out here.
nvaytet
commented
Feb 6, 2026
|
|
||
| # Default parameters | ||
| wf[PulseStrideOffset] = None | ||
| wf[LookupTableRelativeErrorThreshold] = 1.0 |
Member
Author
There was a problem hiding this comment.
Should the default be something like np.inf?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion here: scipp/essdiffraction#236 (comment)
Instead of hard-coding the error threshold on the LUTs saved to disk, we mask later, in the
GenericTofWorkflow.The
LookupTableRelativeErrorThresholdis now a parameter of the mainGenericTofWorkflowinstead of the workflow that builds the table, and can be set by the user.This means that scientists can control what threshold they want to apply.
We set a default value on the workflow so that we don't break existing workflows and notebooks.