Skip to content

Fix Firefox manifest validation and update PR CI workflow#3

Merged
scolastico merged 3 commits intomainfrom
copilot/fix-invalid-extension-error
Jan 28, 2026
Merged

Fix Firefox manifest validation and update PR CI workflow#3
scolastico merged 3 commits intomainfrom
copilot/fix-invalid-extension-error

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

Firefox's WebExtensions API requires browser_specific_settings.gecko.data_collection_permissions to be an object or omitted. The manifest incorrectly set it to false, causing validation failure.

Changes

  • Removed data_collection_permissions: false from src/manifest.json
  • Updated .github/workflows/pr-build.yml to replace "IN-DEV" version with "0.0.0" before building PR artifacts

The data_collection_permissions field is optional; omitting it is semantically equivalent to false while being spec-compliant.

The PR CI workflow now follows the same pattern as the release workflow, ensuring that PR builds generate artifacts with a valid semver version instead of the development placeholder "IN-DEV".


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…missions field

Co-authored-by: scolastico <26954501+scolastico@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix invalid extension error in manifest file Fix Firefox manifest validation: remove invalid data_collection_permissions field Jan 28, 2026
Copilot AI requested a review from scolastico January 28, 2026 11:13
@scolastico
Copy link
Member

@copilot update the ci for pr's to replace IN-DEV with 0.0.0

Co-authored-by: scolastico <26954501+scolastico@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 28, 2026

@copilot update the ci for pr's to replace IN-DEV with 0.0.0

Updated the PR CI workflow to replace "IN-DEV" with "0.0.0" before building. The change adds a new step that uses jq to update the manifest version, similar to the release workflow. (c3665f9)

Copilot AI changed the title Fix Firefox manifest validation: remove invalid data_collection_permissions field Fix Firefox manifest validation and update PR CI workflow Jan 28, 2026
@scolastico scolastico marked this pull request as ready for review January 28, 2026 11:18
@github-actions
Copy link

🎉 Addon Build Complete

The addon has been successfully built for this PR!

Version: 0.0.0
Build: #21436043168

You can download the built addon from the artifacts section of the workflow run.

Installation Instructions

  1. Download the artifact from the workflow run
  2. Extract the zip file
  3. Load the extension in your browser:
    • Firefox: Navigate to about:debugging#/runtime/this-firefox, click "Load Temporary Add-on", and select the manifest.json
    • Chrome: Navigate to chrome://extensions, enable "Developer mode", click "Load unpacked", and select the extracted folder

@scolastico scolastico merged commit ee683c3 into main Jan 28, 2026
1 check passed
@scolastico scolastico deleted the copilot/fix-invalid-extension-error branch January 28, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants